Add radioactivity #1345
Merged
Add radioactivity #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 28, 2023 00:14
|
If this PR gets accepted, I will continue with more radioactivity-related stuff. Here, feel warned. |
|
Looks perfect to me, thanks! I think this is a good fit for the library, so any further work on radioactivity is probably also a good fit. Just keep in mind that the library generally tries to strike a balance between providing what most people need, while not adding too many esoteric or very specialized units that will only be useful to a handful of users. |
|
Nuget should be out shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Radioactivity (radioactive decay), along with three units: Bq - Becquerel (SI-derived), Ci - Curie and Rd - Rutherford (both non-SI).
The scope of prefixes is fairly wide (Pico- to Exa- for Becquerel , Pico- to Tera- for Curie and Rutherford) in order to support most common scenarios, like measuring concentration of radioactive elements in a substance (e.g. 10 Bq per m3 of air is considered normal), rate of radioactive decay in electrical parts, Geiger counter scales, cosmic ray interactions or even global inventory of specific radioactive elements (per Wikipedia). It does not, however, support prefixes for things like activity produced by nuclear explosions (values beyond 10^24 Bq), since this seems too niche even for C# devs.
Similar PR was already created a quople years back (#915), but it was never actually merged.