fix(cli): fix setting flag to false #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since |
sjelin
suggested changes
Nov 8, 2016
| @@ -31,22 +31,33 @@ export class Option { | |||
|
|
|||
| getNumber(): number { | |||
| let value = this.getValue_(); | |||
| if (value && typeof value === 'number') { | |||
| return +value; | |||
| if (value) { | |||
There was a problem hiding this comment.
Good catch. My fix is for strings or numbers to return the +value. For booleans, I plan to return null.
|
I agree. I'll put tests together. |
cnishina
force-pushed
the
cli_issues
branch
5 times, most recently
from
cefc610 to
9bebf21
Compare
sjelin
reviewed
Nov 10, 2016
| return Boolean(value); | ||
| if (value != null) { | ||
| if (typeof value === 'string') { | ||
| return !Boolean(value === '0' || value === 'false'); |
There was a problem hiding this comment.
Why the use of Boolean? The inside is clearly a boolean
| if (typeof value === 'string') { | ||
| return !Boolean(value === '0' || value === 'false'); | ||
| } else if (typeof value === 'number') { | ||
| return Boolean(value !== 0); |
- This fixes `webdriver-manager update --gecko=false` - This does not fix `webdriver-manager update --gecko=0`. Minimist interprets 0 as true. - Add options and programs unit tests closes angular#110
|
Done. |
sjelin
approved these changes
Nov 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webdriver-manager update --gecko=falsewebdriver-manager update --gecko=0. Minimist interprets 0 as true.closes #110