fix(cli): fix setting flag to false

- This fixes `webdriver-manager update --gecko=false` - This does not fix `webdriver-manager update --gecko=0`. Minimist interprets 0 as true. closes #110
angular · Nov 8, 2016 · f289d44 · f289d44
1 parent f536a76
commit f289d44
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 8 deletions.
diff --git a/lib/cli/options.ts b/lib/cli/options.ts
@@ -31,22 +31,33 @@ export class Option {
 
   getNumber(): number {
     let value = this.getValue_();
-    if (value && typeof value === 'number') {
-      return +value;
+    if (value) {
+      return +this.getValue_();
+    } else {
+      return null;
     }
-    return null;
   }
 
   getString(): string {
     let value = this.getValue_();
-    if (value && typeof value === 'string') {
-      return '' + value;
+    if (value != null) {
+      return '' + this.getValue_();
+    } else {
+      return '';
     }
-    return '';
   }
 
   getBoolean(): boolean {
     let value = this.getValue_();
-    return Boolean(value);
+    if (value != null) {
+      if (typeof value === 'string') {
+        return !Boolean(value === '0' || value === 'false');
+      } else if (typeof value === 'number') {
+        return Boolean(value !== 0);
+      } else {
+        return value;
+      }
+    }
+    return false;
   }
 }
diff --git a/lib/cli/programs.ts b/lib/cli/programs.ts
@@ -83,7 +83,7 @@ export class Program {
     let tempJson: any = json;
     while (keyList.length > 0) {
       let keyItem = keyList[0];
-      if (tempJson[keyItem]) {
+      if (tempJson[keyItem] != null) {
         tempJson = tempJson[keyItem];
         keyList = keyList.slice(1);
       } else {