Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

fix: prototype Pollution vulnerability through outdated yargs package #5432

Merged
merged 6 commits into from
May 8, 2020
Merged

fix: prototype Pollution vulnerability through outdated yargs package #5432

merged 6 commits into from
May 8, 2020

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented May 7, 2020 •
edited
Loading

See individual commits.

Closes #5431

@alan-agius4 alan-agius4 requested a review from kyliau May 7, 2020 11:58
@alan-agius4 alan-agius4 marked this pull request as draft May 7, 2020 12:07
@alan-agius4 alan-agius4 removed the request for review from kyliau May 7, 2020 12:07
@alan-agius4
fix: prototype Pollution vulnerability through outdated yargs package
20bfc61 
BREAKING CHANGE:

Node.Js version 6 and 8 are no longer supported. Please update to Node.Js 10+

Closes angular#5431
@alan-agius4
build: update several dev packages that have security issues
7419c6b
@alan-agius4
refactor: remove debugger and explore methods
73f6f4a 
BREAKING CHANGE:
Debugger and explore methods are not compatable with Node 8+. Use `debugger` keyword instead. See: https://goo.gl/MvWqFh
@alan-agius4
refactor: use console.log instead of util.puts
7622aae 
utils.puts is no longer available in Node.JS 12
@alan-agius4 alan-agius4 marked this pull request as ready for review May 8, 2020 10:35
@alan-agius4 alan-agius4 requested a review from kyliau May 8, 2020 10:35
kyliau
kyliau approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@kyliau kyliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@kyliau kyliau merged commit 9d2e18e into angular:release-5.4 May 8, 2020
@alan-agius4 alan-agius4 deleted the update-yargs branch May 8, 2020 18:26
@alan-agius4 alan-agius4 mentioned this pull request May 8, 2020
Closed
@aubsolete aubsolete mentioned this pull request Aug 24, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kyliau kyliau kyliau approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alan-agius4 @kyliau @googlebot