Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Protractor website title could confuse developers #5459

Open
Akkora opened this issue Jul 22, 2020 · 6 comments
Open

Protractor website title could confuse developers #5459

Akkora opened this issue Jul 22, 2020 · 6 comments

Comments

@Akkora
Copy link

Akkora commented Jul 22, 2020

The website at https://www.protractortest.org has only AngularJS in the title.
<title>Protractor - end-to-end testing for AngularJS</title>

protractor-google

Solution:

Remove JS :) (I know, it works for both... but on other places like the logo and description texts only Angular is written)
<title>Protractor - end-to-end testing for Angular</title>

@abhinaba-ghosh
Copy link

I suggest removing the Angular part too. As many teams successfully using protractor for other technologies. If anyone uses protractor-react-selector plugin, then they have the API browser.wwaitForReact() as well. So, I think it should become a framework agnostic.

@aubsolete
Copy link

@Akkora @abhinaba-ghosh unless either of you have begun working on this, would you mind if I get started on it?

@abhinaba-ghosh
Copy link

you can go-ahead 🐎

@aubsolete
Copy link

Protractor is an end-to-end test framework for Angular and AngularJS applications. Protractor runs tests against your application running in a real browser, interacting with it as a user would.

The intro description also mentions Angular and AngularJS. Would you like these removed, too? It could be rewritten to something such as:

Protractor is an end-to-end test framework that runs tests against your application running in a real browser, interacting with it as a user would.

@aubsolete
Copy link

Sorry for the delay, I have been running into some issues with this task and I don't think I'm getting very far on my own. I am a new contributor to Protractor, so I haven't set it up locally before. When I installed everything and followed the instructions for running the website, I got an error due to the code for compile_to_es5 having been deleted - I believe in PR#5432. I re-added the code thinking it was an accident, but I have since been running into other issues. If the deletion was intentional, what would be the correct way to run the website now? Thanks in advance for any help.

@magneticflux-
Copy link

@aubsolete

Sorry for the delay, I have been running into some issues with this task and I don't think I'm getting very far on my own. I am a new contributor to Protractor, so I haven't set it up locally before. When I installed everything and followed the instructions for running the website, I got an error due to the code for compile_to_es5 having been deleted - I believe in PR#5432. I re-added the code thinking it was an accident, but I have since been running into other issues. If the deletion was intentional, what would be the correct way to run the website now? Thanks in advance for any help.

Just in case this is still an issue: I believe the new way to compile is by running npm prepublish.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants