Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

bug(debugger): breakpoint isn't set properly for windows #1850

Closed
wants to merge 1 commit into from

Conversation

hankduan
Copy link
Contributor

No description provided.

@juliemr
Copy link
Member

juliemr commented Feb 25, 2015

Change the commit message to fix(debugger) and then LGTM.

@hankduan
Copy link
Contributor Author

Oops, I keep doing that =(. Done and committed aabdd56

@hankduan hankduan closed this Feb 25, 2015
@alfonso-presa
Copy link
Contributor

It still doesn't seem to work in windows 7 32bits. I'm in protractor 1.8.0 and I've confirmed that this PR patch is applied in it's code. I'm running the following command:
node_modules.bin\protractor .\test\protractor.conf.js --elementExplorer

It gets stucked after the message "Debugger listening on port 5858" and seems to never enter command Repl mode.

I've tried to debug protractor's code and it seems like it's never reaching line 667 of protractor.js inside pausePromise object. Look's like a failure in webdriver.promise.controlFlow().execute() because I've also tried running require('child_process').fork(debuggerClientPath, [process.debugPort]); outside of pausePromise (without using flow.execute) and the debugger starts, but it's obviously a lot buggy.

If you give me any clues of where to keep on debugging I can continue trying to figure out the prob in my windows machine.

edit: I forgot to say that chrome's window does raise but never navigates to the URL in protractor.conf.js or provided by baseURL parameter.

@MystK
Copy link

MystK commented Mar 11, 2015

Same exact issue here, although I am using iojs v1.4.3. Are you on node, Alfonso?

@hankduan
Copy link
Contributor Author

iojs 1.4.3 is forked from node 0.10.35. All versions of node (or forks of node) above 0.10.30 won't work because of this issue here (nodejs/node-v0.x-archive#9333)

I have a patch that makes element explorer compatible with higher versions of node (#1898) but until node (or iojs I guess) fixes the bug, it's not going to help much.

@MystK
Copy link

MystK commented Mar 11, 2015

Thanks for the reply. I didn't know this was due to a bug in Node.

@hankduan
Copy link
Contributor Author

Well, it's partly Node's bug (which makes element explorer extremely laggy to use -- linked above) and partly element explorer's incompatibility with higher levels of node.
The latter I fixed in the PR I linked, but there's no point to submit until node fix the lag issue because whatever they do could require me to make further changes to that PR to make element explorer compatible.

@alfonso-presa
Copy link
Contributor

Thank you for the replies.

Yes. I'm in node v0.12.0 indeed.

I'll try the patch and also wait for nodes fix.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants