Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-multiline attribute on Autocomplete #7100

Closed
vertigo7x opened this issue Sep 15, 2017 · 1 comment · Fixed by #7107
Closed

aria-multiline attribute on Autocomplete #7100

vertigo7x opened this issue Sep 15, 2017 · 1 comment · Fixed by #7107
Assignees
Labels
Accessibility This issue is related to accessibility (a11y) help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@vertigo7x
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Pass wai-aria validation using Axe

What is the current behavior?

The autocomplete component have an input with an attribute aria-multiline set to false, but the specification wai-aria-1.1 says that the child element should have the aria-multiline attribute:

A composite widget containing a single-line textbox and another element, such as a listbox or grid, that can dynamically pop up to help the user set the value of the textbox.
Authors must ensure an element with role combobox contains or owns a text input element with role textbox or searchbox and that the text input has aria-multiline set to false. If the combobox provides autocompletion behavior for the text input as described in aria-autocomplete, authors must set aria-autocomplete on the textbox element to the value that corresponds to the provided behavior.

What are the steps to reproduce?

Pass accessibility validation using Axe for Chrome on Autocomplete

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

material 2.0.0-beta.10

@jelbourn jelbourn added Accessibility This issue is related to accessibility (a11y) help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Sep 15, 2017
@crisbeto crisbeto self-assigned this Sep 15, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 15, 2017
Removes the `aria-multiline` attribute, because it is not allowed on a `role="combobox"`.

Fixes angular#7100.
andrewseguin pushed a commit that referenced this issue Sep 29, 2017
Removes the `aria-multiline` attribute, because it is not allowed on a `role="combobox"`.

Fixes #7100.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants