Skip to content

Commit

Permalink
fix(autocomplete): remove invalid aria markup (#7107)
Browse files Browse the repository at this point in the history
Removes the `aria-multiline` attribute, because it is not allowed on a `role="combobox"`.

Fixes #7100.
  • Loading branch information
crisbeto authored and andrewseguin committed Sep 29, 2017
1 parent daa3880 commit 6bd6b9f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion src/lib/autocomplete/autocomplete-trigger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ export function getMatAutocompleteMissingPanelError(): Error {
'role': 'combobox',
'autocomplete': 'off',
'aria-autocomplete': 'list',
'aria-multiline': 'false',
'[attr.aria-activedescendant]': 'activeOption?.id',
'[attr.aria-expanded]': 'panelOpen.toString()',
'[attr.aria-owns]': 'autocomplete?.id',
Expand Down
5 changes: 0 additions & 5 deletions src/lib/autocomplete/autocomplete.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1154,11 +1154,6 @@ describe('MatAutocomplete', () => {
.toEqual('list', 'Expected aria-autocomplete attribute to equal list.');
});

it('should set aria-multiline to false', () => {
expect(input.getAttribute('aria-multiline'))
.toEqual('false', 'Expected aria-multiline attribute to equal false.');
});

it('should set aria-activedescendant based on the active option', async(() => {
fixture.componentInstance.trigger.openPanel();
fixture.detectChanges();
Expand Down

0 comments on commit 6bd6b9f

Please sign in to comment.