Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): remove invalid aria markup #7107

Merged
merged 1 commit into from
Sep 29, 2017
Merged

fix(autocomplete): remove invalid aria markup #7107

merged 1 commit into from
Sep 29, 2017

Conversation

crisbeto
Copy link
Member

Removes the aria-multiline attribute, because it is not allowed on a role="combobox".

Fixes #7100.

@crisbeto
fix(autocomplete): remove invalid aria markup
426970c 
Removes the `aria-multiline` attribute, because it is not allowed on a `role="combobox"`.

Fixes angular#7100.
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) pr: needs review labels Sep 15, 2017
@crisbeto crisbeto requested a review from kara as a code owner September 15, 2017 17:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 15, 2017
jelbourn
jelbourn approved these changes Sep 15, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 15, 2017
@andrewseguin andrewseguin merged commit 6bd6b9f into angular:master Sep 29, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aria-multiline attribute on Autocomplete
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin