This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
fix(material-docs-app): remove absolute positioning of all content #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Splaktar
commented
Jul 21, 2020
Splaktar
commented
- preserve behavior of not having a scrollbar next to the toolbar
- hide theme picker on small devices (iPhone 5) so that navbar doesn't wrap
Splaktar
force-pushed
the
remove-absolute-content-position
branch
2 times, most recently
from
4c7b2b6 to
4f949fc
Compare
mmalerba
reviewed
Jul 23, 2020
Splaktar
force-pushed
the
remove-absolute-content-position
branch
from
4f949fc to
c140b1a
Compare
|
Conflicts resolved. |
Splaktar
force-pushed
the
remove-absolute-content-position
branch
from
c140b1a to
2d6ab79
Compare
Splaktar
force-pushed
the
remove-absolute-content-position
branch
from
2d6ab79 to
c2c0adf
Compare
|
The missing 2 points from the LH a11y audit of the custom form field guide is fixed in PR angular/components#21750. |
Splaktar
force-pushed
the
remove-absolute-content-position
branch
2 times, most recently
from
e0b0706 to
ef5d3b0
Compare
|
The other 2 missing points from the LH a11y audit for the Getting Started Guide are fixed in PR angular/components#21751. |
Splaktar
force-pushed
the
remove-absolute-content-position
branch
from
ef5d3b0 to
e1090b4
Compare
- preserve behavior of not having a scrollbar next to the toolbar - hide theme picker on small devices (iPhone 5) so that navbar doesn't wrap
Splaktar
force-pushed
the
remove-absolute-content-position
branch
from
e1090b4 to
57a08e5
Compare
|
OK, this should be ready to go now. |
This was referenced Feb 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.