Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: create anchors for all header elems & fix a11y in guides #21751

Merged
merged 1 commit into from
Feb 5, 2021
Merged

docs: create anchors for all header elems & fix a11y in guides #21751

merged 1 commit into from
Feb 5, 2021

Conversation

Splaktar
Copy link
Member

  • Lighthouse's a11y audit wants page headers to progress in order
  • Go through all guides and make the headers consistent
    • and ordered to pass the a11y audit
  • fix grammar issues and typos

Before

Screen Shot 2021-01-30 at 03 36 01

@Splaktar Splaktar added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation target: patch This PR is targeted for the next patch release labels Jan 30, 2021
@Splaktar Splaktar requested a review from jelbourn January 30, 2021 08:37
@Splaktar Splaktar self-assigned this Jan 30, 2021
@Splaktar Splaktar requested a review from a team as a code owner January 30, 2021 08:37
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 30, 2021
@Splaktar Splaktar mentioned this pull request Jan 30, 2021
Merged
@Splaktar Splaktar force-pushed the guides-fix-a11y-header-issues branch from 267849b to a36e269 Compare January 30, 2021 08:41
crisbeto
crisbeto approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

guides/theming.md Outdated Show resolved Hide resolved
tools/markdown-to-html/docs-marked-renderer.ts Outdated Show resolved Hide resolved
@Splaktar Splaktar force-pushed the guides-fix-a11y-header-issues branch from a36e269 to bbef296 Compare January 30, 2021 20:01
@Splaktar Splaktar changed the title docs(guides): create anchors for h2 elements and fix headers' a11y docs(guides): create anchors for all header elements and fix headers' a11y Jan 30, 2021
@Splaktar Splaktar changed the title docs(guides): create anchors for all header elements and fix headers' a11y docs: create anchors for all header elems & fix a11y in guides Jan 30, 2021
@Splaktar Splaktar force-pushed the guides-fix-a11y-header-issues branch from bbef296 to 2fa693d Compare January 30, 2021 21:19
jelbourn
jelbourn approved these changes Feb 1, 2021
View reviewed changes
guides/using-component-harnesses.md Outdated Show resolved Hide resolved
guides/using-component-harnesses.md Outdated Show resolved Hide resolved
@Splaktar
docs: create anchors for all header elems & fix a11y in guides
3528bc0 
- Lighthouse's a11y audit wants page headers to progress in order
  - https://web.dev/heading-order/
- Go through all guides and make the headers consistent
  - and ordered to pass the a11y audit
- fix grammar issues and typos
@Splaktar Splaktar force-pushed the guides-fix-a11y-header-issues branch from 2fa693d to 3528bc0 Compare February 5, 2021 01:33
@Splaktar Splaktar added the action: merge The PR is ready for merge by the caretaker label Feb 5, 2021
@annieyw annieyw merged commit 9db31ee into angular:master Feb 5, 2021
annieyw pushed a commit that referenced this pull request Feb 5, 2021
@Splaktar @annieyw
docs: create anchors for all header elems & fix a11y in guides (#21751)
ad8c8ac 
- Lighthouse's a11y audit wants page headers to progress in order
  - https://web.dev/heading-order/
- Go through all guides and make the headers consistent
  - and ordered to pass the a11y audit
- fix grammar issues and typos

(cherry picked from commit 9db31ee)
annieyw pushed a commit that referenced this pull request Feb 5, 2021
@Splaktar @annieyw
docs: create anchors for all header elems & fix a11y in guides (#21751)
8e215af 
- Lighthouse's a11y audit wants page headers to progress in order
  - https://web.dev/heading-order/
- Go through all guides and make the headers consistent
  - and ordered to pass the a11y audit
- fix grammar issues and typos

(cherry picked from commit 9db31ee)
@Splaktar Splaktar deleted the guides-fix-a11y-header-issues branch February 5, 2021 14:59
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@Splaktar @wagnermaciel
docs: create anchors for all header elems & fix a11y in guides (angul…
8fa3ace 
…ar#21751)

- Lighthouse's a11y audit wants page headers to progress in order
  - https://web.dev/heading-order/
- Go through all guides and make the headers consistent
  - and ordered to pass the a11y audit
- fix grammar issues and typos
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@Splaktar @wagnermaciel
docs: create anchors for all header elems & fix a11y in guides (angul…
d85a69d 
…ar#21751)

- Lighthouse's a11y audit wants page headers to progress in order
  - https://web.dev/heading-order/
- Go through all guides and make the headers consistent
  - and ordered to pass the a11y audit
- fix grammar issues and typos
@jelbourn jelbourn mentioned this pull request Mar 5, 2021
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees

@Splaktar Splaktar

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Splaktar @jelbourn @crisbeto @annieyw