Skip to content
This repository has been archived by the owner on Apr 9, 2022. It is now read-only.

fix(@schematics/angular): sync up application and component spec schematics #233

Closed

Conversation

trimeyko
Copy link

Fix #182

add blank lines to sync up with other spec schematics in app.component.spec,
add async usage to component schematics

@hansl
Copy link
Contributor

hansl commented Feb 22, 2018

This should be in the next major (0.4 of DevKit, 6.0 of CLI).

@Brocco
Copy link
Contributor

Brocco commented May 16, 2018

@trimeyko Could you please rebase this PR?

@trimeyko
Copy link
Author

@Brocco sure, but is there any decision on async() in default schematics ? See #224 discussion.

@alexeagle
Copy link
Contributor

Sorry @trimeyko - this got lost when we moved back to the angular/angular-cli repo. If you still think this pull request is relevant, could you please re-base on that repo and open a new PR there? Thanks and sorry for the extra churn.

@alexeagle alexeagle closed this Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants