Skip to content
This repository has been archived by the owner on Apr 9, 2022. It is now read-only.

__name@dasherize__.component.spec.ts don't use async in spec case #182

Closed
trimeyko opened this issue Sep 29, 2017 · 1 comment
Closed

__name@dasherize__.component.spec.ts don't use async in spec case #182

trimeyko opened this issue Sep 29, 2017 · 1 comment
Labels
comp: schematics/angular freq1: low severity1: confusing type: bug

Comments

@trimeyko
Copy link

Component spec file scheme is old and not consistent with spec in new app since it's not using async() in spec case, should be used by default.

component:
https://github.com/angular/devkit/blob/master/packages/schematics/angular/component/files/__path__/__name%40dasherize%40if-flat__/__name%40dasherize__.component.spec.ts

spec in new app:
https://github.com/angular/devkit/blob/master/packages/schematics/angular/application/other-files/app.component.spec.ts
trimeyko pushed a commit to trimeyko/devkit that referenced this issue Oct 23, 2017
fix(@schematics/angular): sync up application and component spec sche…
488b3f6 
…matics

Fix angular#182
@trimeyko trimeyko mentioned this issue Oct 23, 2017
Closed
trimeyko added a commit to trimeyko/devkit that referenced this issue Oct 23, 2017
@trimeyko
fix(@schematics/angular): sync up application and component spec sche…
5738941 
…matics

Fix angular#182
This was referenced Oct 23, 2017
Closed
Closed
@alexeagle alexeagle mentioned this issue Sep 5, 2018
Closed
@alexeagle
Copy link
Contributor

This issue was moved to angular/angular-cli#12161

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
comp: schematics/angular freq1: low severity1: confusing type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexeagle @trimeyko @Brocco @filipesilva