Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(ripple): handle touch events #7557

Merged
merged 1 commit into from
Oct 6, 2017

Commits on Oct 6, 2017

  1. revert(ripple): handle touch events

    Reverts the `ripple(): handle touch events` commit from PR#7299. With the current touch solution, ripples are showing up twice on click.
    
    This is because after a `touchstart` event, the touch browser fires a `mousedown` event. This causes the ripple renderer to fade in another ripple from the `mousedown` event.
    
    There are solutions like:
    
    * Timeout to ignore `mousedown` events
    * Calling `preventDefault` / `stopPropagation` on `touchstart`
    * Listening to `pointerdown`, `pointerup`, `pointerleave` events
    * Using feature detecton (as in Modernizr)
    
    All of those solutions have negative aspects on the UX of the ripples and need to be evaluated with more testing.
    
    For now the ripples are broken and should be fixed as soon as possible. This is going to be revisited.
    devversion committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    89cad8b View commit details
    Browse the repository at this point in the history