revert(ripple): handle touch events #7557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
approved these changes
Oct 5, 2017
crisbeto
added
pr: lgtm
action: merge
crisbeto
reviewed
Oct 5, 2017
| this._isPointerDown = true; | ||
| this.fadeInRipple(event.clientX, event.clientY, this.rippleConfig); | ||
| this._isMousedown = true; | ||
| this.fadeInRipple(event.pageX, event.pageY, this.rippleConfig); |
There was a problem hiding this comment.
Sorry, just took another look. This should use clientX and clientY.
There was a problem hiding this comment.
Updated it and fixed a lint error. Please have another look.
devversion
force-pushed
the
revert/touch-events-ripple
branch
from
058fecc
to
7d2e294
Compare
Reverts the `ripple(): handle touch events` commit from PR#7299. With the current touch solution, ripples are showing up twice on click. This is because after a `touchstart` event, the touch browser fires a `mousedown` event. This causes the ripple renderer to fade in another ripple from the `mousedown` event. There are solutions like: * Timeout to ignore `mousedown` events * Calling `preventDefault` / `stopPropagation` on `touchstart` * Listening to `pointerdown`, `pointerup`, `pointerleave` events * Using feature detecton (as in Modernizr) All of those solutions have negative aspects on the UX of the ripples and need to be evaluated with more testing. For now the ripples are broken and should be fixed as soon as possible. This is going to be revisited.
devversion
force-pushed
the
revert/touch-events-ripple
branch
from
7d2e294
to
89cad8b
Compare
jelbourn
added
P1
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the
ripple(): handle touch eventscommit from PR #7299. With the current touch solution, ripples are showing up twice on click.This is because after a
touchstartevent, the touch browser fires amousedownevent. This causes the ripple renderer to fade in another ripple from themousedownevent.There are solutions like:
mousedowneventspreventDefault/stopPropagationontouchstartpointerdown,pointerup,pointerleaveeventsAll of those solutions have negative aspects on the UX of the ripples and need to be evaluated with more testing.
For now the ripples are broken and should be fixed as soon as possible. This is going to be revisited.