Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dialog): switch to OnPush change detection #6287

Merged
merged 1 commit into from
Aug 16, 2017
Merged

chore(dialog): switch to OnPush change detection #6287

merged 1 commit into from
Aug 16, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 5, 2017

Switches the dialog to OnPush change detection.

Note: This is the same changeset as #5422. I've had to reopen it since it wasn't possible to rebase #6126.

@crisbeto crisbeto requested a review from jelbourn as a code owner August 5, 2017 07:44
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 5, 2017
@jelbourn jelbourn added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note pr: lgtm action: merge The PR is ready for merge by the caretaker presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged and removed pr: needs review labels Aug 9, 2017
@jelbourn
Copy link
Member

jelbourn commented Aug 9, 2017

Caretaker note: there is at least one screenshot test that indicates this might break some stuff, needs further investigation

@jelbourn jelbourn mentioned this pull request Aug 9, 2017
Closed
@andrewseguin
Copy link
Contributor

Please rebase

@crisbeto
chore(dialog): switch to OnPush change detection
0c9b0b3 
Switches the dialog to OnPush change detection.
@andrewseguin andrewseguin merged commit 72360e2 into angular:master Aug 16, 2017
andrewseguin added a commit to andrewseguin/components that referenced this pull request Aug 17, 2017
@andrewseguin
Revert "chore(dialog): switch to OnPush change detection (angular#6287)"
cbb5579 
This reverts commit 72360e2.
andrewseguin added a commit that referenced this pull request Aug 17, 2017
@andrewseguin
Revert "chore(dialog): switch to OnPush change detection (#6287)" (#6523
0f02a11 
)

This reverts commit 72360e2.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @andrewseguin @googlebot