Skip to content

Commit

Permalink
chore(dialog): switch to OnPush change detection
Browse files Browse the repository at this point in the history
Switches the dialog to OnPush change detection.
  • Loading branch information
crisbeto committed Aug 5, 2017
1 parent 0850981 commit c949ce1
Showing 1 changed file with 15 additions and 2 deletions.
17 changes: 15 additions & 2 deletions src/lib/dialog/dialog-container.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
Inject,
Optional,
ChangeDetectorRef,
ChangeDetectionStrategy,
} from '@angular/core';
import {
animate,
Expand Down Expand Up @@ -51,6 +52,7 @@ export function throwMdDialogContentAlreadyAttachedError() {
templateUrl: 'dialog-container.html',
styleUrls: ['dialog.css'],
encapsulation: ViewEncapsulation.None,
changeDetection: ChangeDetectionStrategy.OnPush,
animations: [
trigger('slideDialog', [
// Note: The `enter` animation doesn't transition to something like `translate3d(0, 0, 0)
Expand Down Expand Up @@ -118,7 +120,13 @@ export class MdDialogContainer extends BasePortalHost {
}

this._savePreviouslyFocusedElement();
return this._portalHost.attachComponentPortal(portal);

const componentRef = this._portalHost.attachComponentPortal(portal);

// Ensure that the initial view change are picked up.
componentRef.changeDetectorRef.markForCheck();

return componentRef;
}

/**
Expand All @@ -131,7 +139,12 @@ export class MdDialogContainer extends BasePortalHost {
}

this._savePreviouslyFocusedElement();
return this._portalHost.attachTemplatePortal(portal);

const locals = this._portalHost.attachTemplatePortal(portal);

this._changeDetectorRef.markForCheck();

return locals;
}

/** Moves the focus inside the focus trap. */
Expand Down

0 comments on commit c949ce1

Please sign in to comment.