fix(expansion-panel): toggle not being updated when set programmatically #5650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
5623/expansion-panel-on-push
branch
from
abd3779
to
d58124c
Compare
jelbourn
reviewed
Jul 25, 2017
| panel.closed, | ||
| filter.call(panel._inputChanges, changes => !!changes.hideToggle) | ||
| ) | ||
| .subscribe(() => this._changeDetectorRef.markForCheck()); |
There was a problem hiding this comment.
Would it be possible to add a unit test for this case?
There was a problem hiding this comment.
I can give it a try, but I feel like the manual change detection might cause it not to fail as expected.
crisbeto
force-pushed
the
5623/expansion-panel-on-push
branch
from
d58124c
to
9687d06
Compare
|
Added those unit tests as discussed @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from angular#5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow. Fixes angular#5623.
crisbeto
force-pushed
the
5623/expansion-panel-on-push
branch
from
9687d06
to
d09d215
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the toggle arrow not being flipped when the
expandedis set programmatically, in addition to thehideToggleinput not working either. This is a regression from #5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow.Fixes #5623.
Note: Similarly to #5631, if we want something more practical, we'll have to re-think where the input for these properties should go.