chore(expansion-panel): switch to OnPush change detection #5549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jul 6, 2017
src/lib/expansion/accordion-item.ts
Outdated
| @@ -44,6 +52,8 @@ export class AccordionItem implements OnDestroy { | |||
| } else { | |||
| this.closed.emit(); | |||
| } | |||
|
|
|||
| this._changeDetectorRef.markForCheck(); | |||
There was a problem hiding this comment.
Add a comment that mentions what sets expanded outside of the normal @Input binding?
* Switches the expansion panel to `OnPush` change detection. * Fixes the open animation not triggering on the body element. Relates to angular#5035.
crisbeto
force-pushed
the
5035/expansion-panel
branch
from
50aa7ce
to
c2996a2
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 10, 2017
Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from angular#5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow. Fixes angular#5623.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 25, 2017
Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from angular#5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow. Fixes angular#5623.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 26, 2017
Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from angular#5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow. Fixes angular#5623.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 27, 2017
Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from angular#5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow. Fixes angular#5623.
andrewseguin
pushed a commit
that referenced
this pull request
Jul 28, 2017
…lly (#5650) * fix(expansion-panel): toggle not being updated when set programmatically Fixes the toggle arrow not being flipped when the `expanded` is set programmatically, in addition to the `hideToggle` input not working either. This is a regression from #5549 and is a consequence of the fact that the panel header reaches into the panel to determine what to do with the arrow. Fixes #5623. * chore: add a couple of unit tests for the fixes
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnPushchange detection.Relates to #5035.