-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): add progress-fab component #290
Conversation
f16d70d
to
e821cea
Compare
@devversion Now needs rebasing on my mega change #384; feel free to ping me if you run into any issues |
e821cea
to
09e8561
Compare
@jelbourn Done. |
09e8561
to
3fb2ad1
Compare
builder = tcb; | ||
})); | ||
|
||
it('should correctly apply the color attribute on the progress circle', (done: () => void) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the new async
function instead of the done
callback now
@devversion sorry for the delay on this PR, I need to set some time aside to see what the a11y story for this component should be. |
@jelbourn It's no problem :) Just ping me on the PR, once you like to revisit it. |
<ng-content></ng-content> | ||
|
||
<div class="md-progress-wrap"> | ||
<md-progress-circle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be announced, this progress circle needs to be a sibling to the focusable button, and it needs role="progressbar"
along with other related ARIA attributes: https://www.w3.org/TR/wai-aria/roles#progressbar
Specifically the progressbar needs to specify aria-valuenow
, aria-valuemin
and aria-valuemax
for screen readers to follow along.
Lastly, what is the progress circle indicating (i.e. what is loading)? That binding should be indicated somehow...the ARIA roles spec recommends using aria-describedby
on the progressbar and aria-busy
on whatever is loading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marcysutton, I'll try making the process circle a sibling.
- The role is automatically applied from the Progress Circle Component
- Valuenow, ValueMin, ValueNow are also covered by the circle component.
Forwarding the aria-label
/ or creating a default one, makes definitely sense. thx
To answer @jelbourn's question from #305, this definitely does need some a11y treatment. While the button is the focusable element, the If the progressbar component can't bind itself to whatever is actually loading on the page with |
Going to close this for now, since this is a nice to have component |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The feature is still under discussion. just decided to push it, so others can review and suggest improvements.
https://i.gyazo.com/4cb5fe4e70c4845e58d1c382d95f1eed.mp4
MdProgressFab
MdProgressFab
is a normal FAB button surrounded with aprogress-circle
.Screenshots
[md-progress-fab]
Bound Properties
color
value
number
progress-circle
.Necessary when using the
determinate
mode.mode
progressColor
Examples
A basic progress-fab will have the markup:
It will use by default a
indeterminate
progress circle.