Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(): BroccoliSass should build all source files in relative to the sourceroot. #288

Closed
wants to merge 1 commit into from
Closed

update(): BroccoliSass should build all source files in relative to the sourceroot. #288

wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

  • This allows us to import several styles from other components easily.
    For example needed, when a component is extending from another.
    (Example Progress-Fab)
  • Fixes SCSS validation issues in IDEA's, since the stylesheets are now imported correctly.

@devversion
update(): BroccoliSass should build all source files in relative to t…
54a9a4a 
…he root

* This allows us to import several styles from other components easily.
   For example needed, when a component is extending from another.

* Fixes SCSS validation issues in IDEA's, since the stylesheets are now imported correctly.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 9, 2016
@devversion devversion mentioned this pull request Apr 9, 2016
Closed
@jelbourn
Copy link
Member

I believe @hansl was actually working to resolve this from the CLI side.

@hansl
Copy link
Contributor

hansl commented Apr 11, 2016

Yes, I'm waiting for the next release of the CLI then I'll upgrade Material. We'll have some new goodies.

@devversion
Copy link
Member Author

@hansl Great to hear that. Feel free to close that PR if it's not needed yet 😄 - but notice, that #290 is currently rebased on that commit.

@hansl
Copy link
Contributor

hansl commented Apr 11, 2016

The main difference between that and this PR is the input paths; I'm still using src/core/style as an import path. No big deal though.

@hansl
Copy link
Contributor

hansl commented Apr 11, 2016

Closing this in favor of #293. Cheers!

@hansl hansl closed this Apr 11, 2016
@devversion devversion deleted the update/scss-compilation branch May 13, 2016 13:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@hansl hansl

Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @hansl @googlebot