Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material-experimental/mdc-tabs): default to stretched tabs #23406

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

crisbeto
Copy link
Member

Defaults the MDC tabs to stretch in order to align closer with the spec. A new stretchTabs input can be used to opt out.

Fixes #23295.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Aug 19, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 19, 2021
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Sep 15, 2021
@RadhikaGunisetty
Copy link

@crisbeto This PR needs a rebase, please rebase the PR.

@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
Defaults the MDC tabs to stretch in order to align closer with the spec. A new `stretchTabs` input can be used to opt out.

Fixes angular#23295.
@zarend
Copy link
Contributor

zarend commented Feb 4, 2022

Ran presubmit last night, came back with 48 failures. I briefly looked at them. Many are screenshot diffs where the tabs used to be aligned to the left, but now they are centered.

@zarend zarend added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Feb 4, 2022
@andrewseguin andrewseguin merged commit 1b7d47c into angular:master Mar 7, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
…lar#23406)

Defaults the MDC tabs to stretch in order to align closer with the spec. A new `stretchTabs` input can be used to opt out.

Fixes angular#23295.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(mdc-tabs): Default to stretching tab labels
5 participants