Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(mdc-tabs): Default to stretching tab labels #23295

Closed
andrewseguin opened this issue Aug 2, 2021 · 1 comment · Fixed by #23406
Closed

bug(mdc-tabs): Default to stretching tab labels #23295

andrewseguin opened this issue Aug 2, 2021 · 1 comment · Fixed by #23406
Assignees
@crisbeto
Labels
area: material/tabs feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@andrewseguin
Copy link
Contributor

The spec shows tab labels as stretching to fit the parent container, whereas the current default is to just implement a min-width and allow them to grow. Consider defaulting to stretched tabs rather than expect the user to apply mat-stretch-tabs.
@andrewseguin andrewseguin added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent needs triage This issue needs to be triaged by the team area: material/tabs labels Aug 2, 2021
@crisbeto crisbeto added feature This issue represents a new feature or feature request rather than a bug or bug fix and removed needs triage This issue needs to be triaged by the team labels Aug 4, 2021
@crisbeto crisbeto self-assigned this Aug 19, 2021
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 19, 2021
@crisbeto
feat(material-experimental/mdc-tabs): default to stretched tabs
e445d77 
Defaults the MDC tabs to stretch in order to align closer with the spec. A new `stretchTabs` input can be used to opt out.

Fixes angular#23295.
@crisbeto crisbeto mentioned this issue Aug 19, 2021
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 3, 2022
@crisbeto
feat(material-experimental/mdc-tabs): default to stretched tabs
77ddec2 
Defaults the MDC tabs to stretch in order to align closer with the spec. A new `stretchTabs` input can be used to opt out.

Fixes angular#23295.
andrewseguin pushed a commit that referenced this issue Mar 7, 2022
@crisbeto
feat(material-experimental/mdc-tabs): default to stretched tabs (#23406)
1b7d47c 
Defaults the MDC tabs to stretch in order to align closer with the spec. A new `stretchTabs` input can be used to opt out.

Fixes #23295.
forsti0506 pushed a commit to forsti0506/components that referenced this issue Apr 3, 2022
@crisbeto @forsti0506
feat(material-experimental/mdc-tabs): default to stretched tabs (angu…
5374521 
…lar#23406)

Defaults the MDC tabs to stretch in order to align closer with the spec. A new `stretchTabs` input can be used to opt out.

Fixes angular#23295.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/tabs feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(material-experimental/mdc-tabs): default to stretched tabs crisbeto/material2
2 participants
@crisbeto @andrewseguin