Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add exception for missing MDC test #22188

Merged
merged 1 commit into from
Mar 11, 2021
Merged

build: add exception for missing MDC test #22188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/check-mdc-tests-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ export const config = {
'element is inside an ngIf'
],
'mdc-select': [
// TODO(crisbeto): remove this exception once #22187 lands.
'should float the label on focus if it has a placeholder',

// These tests are excluded, because they're verifying the functionality that positions
// the select panel over the trigger which isn't supported in the MDC select.
'should set the width of the overlay based on a larger trigger width',
Expand Down
8 changes: 4 additions & 4 deletions src/material-experimental/mdc-chips/chip-input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import {MatChipTextControl} from './chip-text-control';

/** Represents an input event on a `matChipInput`. */
export interface MatChipInputEvent {
/**
/**
* The native `<input>` element that the event is being fired for.
* @deprecated Use `MatChipInputEvent#chipInput.inputElement` instead.
* @breaking-change 13.0.0 This property will be removed.
Expand All @@ -34,9 +34,9 @@ export interface MatChipInputEvent {

/** The value of the input. */
value: string;
/**
* Reference to the chip input that emitted the event.

/**
* Reference to the chip input that emitted the event.
* @breaking-change 13.0.0 This property will be made required.
*/
chipInput?: MatChipInput;
Expand Down
8 changes: 4 additions & 4 deletions src/material/chips/chip-input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import {MatChipTextControl} from './chip-text-control';

/** Represents an input event on a `matChipInput`. */
export interface MatChipInputEvent {
/**
/**
* The native `<input>` element that the event is being fired for.
* @deprecated Use `MatChipInputEvent#chipInput.inputElement` instead.
* @breaking-change 13.0.0 This property will be removed.
Expand All @@ -34,9 +34,9 @@ export interface MatChipInputEvent {

/** The value of the input. */
value: string;
/**
* Reference to the chip input that emitted the event.

/**
* Reference to the chip input that emitted the event.
* @breaking-change 13.0.0 This property will be made required.
*/
chipInput?: MatChipInput;
Expand Down