Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add exception for missing MDC test #22188

Merged
merged 1 commit into from
Mar 11, 2021
Merged

build: add exception for missing MDC test #22188

merged 1 commit into from
Mar 11, 2021

Conversation

crisbeto
Copy link
Member

Adds an exception for one missing test until #22187 is merged.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Mar 11, 2021
@crisbeto crisbeto requested a review from a team as a code owner March 11, 2021 08:07
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 11, 2021
@crisbeto
build: add exception for missing MDC test
4ba7ecc 
Adds an exception for one missing test until angular#22187 is merged.
@crisbeto crisbeto force-pushed the mdc-select-exception branch from 4ad8d07 to 4ba7ecc Compare March 11, 2021 08:12
wagnermaciel
wagnermaciel approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Mar 11, 2021
@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 11, 2021
@mmalerba mmalerba merged commit 8a10451 into angular:master Mar 11, 2021
mmalerba pushed a commit that referenced this pull request Mar 11, 2021
@crisbeto @mmalerba
build: add exception for missing MDC test (#22188)
9e39eda 
Adds an exception for one missing test until #22187 is merged.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @wagnermaciel @mmalerba