Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release output validation for manifest paths and downgrade octokit API #18865

Conversation

devversion
Copy link
Member

Cherry-picks parts that still apply from #18785 to the master branch. We merged the PR patch-only, so a few commits are currently missing in the master branch.

*Note: This should be merged master-only.

Ensures that angular/angular@9581658 fixed all instances, and
ensures that we don't regress on the components side.
We recently updated `@octokit/rest`, but the most recent version
currently has broken TypeScript definitions. To workaroun this until
the upstream issue is resolved, we downgrade to our last working version.

https://github.com/octokit/rest.js/issues/1624
@devversion devversion added merge safe merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Mar 19, 2020
@devversion devversion requested review from jelbourn and a team as code owners March 19, 2020 09:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 19, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 19, 2020
@mmalerba mmalerba merged commit 9e1b7ec into angular:master Mar 19, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants