Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to angular v9.0.6 #18785

Merged
merged 3 commits into from
Mar 16, 2020

Conversation

devversion
Copy link
Member

Updates to Angular v9.0.6. This version contains a fix for
@angular/bazel that should fix the release output to not
leak any Bazel runfile manifest paths. angular/angular@9581658

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 11, 2020
@devversion devversion marked this pull request as ready for review March 11, 2020 09:42
@devversion devversion requested review from jelbourn and a team as code owners March 11, 2020 09:42
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Mar 11, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 11, 2020
@devversion devversion added the P2 The issue is important to a large percentage of users, with a workaround label Mar 11, 2020
@andrewseguin
Copy link
Contributor

Needs rebase

@googlebot

This comment has been minimized.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Mar 12, 2020
@devversion devversion changed the base branch from master to 9.1.x March 12, 2020 23:15
@devversion devversion removed needs rebase cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Mar 12, 2020
@devversion
Copy link
Member Author

@googlebot Ping.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 12, 2020
@devversion devversion added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 13, 2020
@devversion
Copy link
Member Author

PR is patch-only due to master being on the Angular beta for TS 3.8 right now.

@andrewseguin
Copy link
Contributor

Uh, I think I broke your PR? Tried merging 9.1.x latest changes into your PR, now failing CI

Updates to Angular v9.0.6. This version contains a fix for
`@angular/bazel` that should fix the release output to not
leak any Bazel runfile manifest paths.

angular/angular@9581658
We recently updated `@octokit/rest`, but the most recent version
currently has broken TypeScript definitions. To workaroun this until
the upstream issue is resolved, we downgrade to our last working version.

https://github.com/octokit/rest.js/issues/1624
Ensures that angular/angular@9581658 fixed all instances, and
ensures that we don't regress on the components side.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants