fix(dialog,bottom-sheet): enter animation blocking child animations #13888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the enter animations for the Material dialog, CDK dialog and bottom sheet are set up to be blocking, which means that any components with an initial animation inside them will be blocked until they're done. These changes allow for the child animations to run in parallel. Fixes angular#13870.
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
…ngular#13888) Currently the enter animations for the Material dialog, CDK dialog and bottom sheet are set up to be blocking, which means that any components with an initial animation inside them will be blocked until they're done. These changes allow for the child animations to run in parallel. Fixes angular#13870.
jelbourn
pushed a commit
that referenced
this pull request
Nov 6, 2018
…13888) Currently the enter animations for the Material dialog, CDK dialog and bottom sheet are set up to be blocking, which means that any components with an initial animation inside them will be blocked until they're done. These changes allow for the child animations to run in parallel. Fixes #13870.
jelbourn
added a commit
to jelbourn/components
that referenced
this pull request
Nov 7, 2018
angular#13674)" (angular#14015)" This reverts commit 11c96d6. Turns out the original change wasn't actually the problem. It was angular#13888 instead.
jelbourn
added a commit
to jelbourn/components
that referenced
this pull request
Nov 7, 2018
…ations (angular#13888)" This reverts commit 235add9. This change broke an app inside of Google where tabs appear inside of a dialog. The tabs get stuck in a weird frozen animation state.
vivian-hu-zz
pushed a commit
that referenced
this pull request
Nov 7, 2018
vivian-hu-zz
pushed a commit
that referenced
this pull request
Nov 12, 2018
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 13, 2018
…ement This is an alternate approach to angular#13888 which had to be reverted due to some presubmit issues. These changes address the problem by providing some default styles that will be applied if the expansion panel is inside an animating element.
virtuoushub
pushed a commit
to virtuoushub/material2
that referenced
this pull request
Nov 26, 2018
…ement This is an alternate approach to angular#13888 which had to be reverted due to some presubmit issues. These changes address the problem by providing some default styles that will be applied if the expansion panel is inside an animating element.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 2, 2019
…ement This is an alternate approach to angular#13888 which had to be reverted due to some presubmit issues. These changes address the problem by providing some default styles that will be applied if the expansion panel is inside an animating element.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 13, 2019
…ement This is an alternate approach to angular#13888 which had to be reverted due to some presubmit issues. These changes address the problem by providing some default styles that will be applied if the expansion panel is inside an animating element.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the enter animations for the Material dialog, CDK dialog and bottom sheet are set up to be blocking, which means that any components with an initial animation inside them will be blocked until they're done. These changes allow for the child animations to run in parallel.
Fixes #13870.