fix(tabs): duplicate animation events on some browsers #13674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes all the animation-related events from the tab body being fired twice. Since a lot of the tabs functionality is tied to animations, this could cause multiple consecutive style recalculations, in addition to the `animationDone` event being fired too many times.
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
Fixes all the animation-related events from the tab body being fired twice. Since a lot of the tabs functionality is tied to animations, this could cause multiple consecutive style recalculations, in addition to the `animationDone` event being fired too many times.
jelbourn
pushed a commit
that referenced
this pull request
Nov 6, 2018
Fixes all the animation-related events from the tab body being fired twice. Since a lot of the tabs functionality is tied to animations, this could cause multiple consecutive style recalculations, in addition to the `animationDone` event being fired too many times.
vivian-hu-zz
pushed a commit
that referenced
this pull request
Nov 7, 2018
jelbourn
added a commit
to jelbourn/components
that referenced
this pull request
Nov 7, 2018
angular#13674)" (angular#14015)" This reverts commit 11c96d6. Turns out the original change wasn't actually the problem. It was angular#13888 instead.
vivian-hu-zz
pushed a commit
that referenced
this pull request
Nov 7, 2018
vivian-hu-zz
pushed a commit
that referenced
this pull request
Nov 12, 2018
vivian-hu-zz
pushed a commit
that referenced
this pull request
Nov 12, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all the animation-related events from the tab body being fired twice. Since a lot of the tabs functionality is tied to animations, this could cause multiple consecutive style recalculations, in addition to the
animationDoneevent being fired too many times.