-
Notifications
You must be signed in to change notification settings - Fork 25.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add TS migration #33250
feat(core): add TS migration #33250
Conversation
You can preview 271ee0f at https://pr33250-271ee0f.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM schematic code-wise. What's the plan for these type of migrations in the future?
On the angular/components side we have this problem that we need to keep migrations forever in our release package due to the way ng update
works (i.e. it installs the latest version and runs migrations for older versions). We are planning on talking about this at some point with the tooling team since we do not want to store all migration code for old versions in our release output (it will blow-up over time).
Same would apply here. I'm just trying to raise awareness as I think that it's not ideal to keep migrations forever in the code-base, plus not all developers use the CLI and we will unnecessarily bloat the @angular/core
package for them (worst case slowing down install if we add more over time). Weren't these type of migrations part of the CLI in the past?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This migration has two distinct parts:
- typescript update
- @types/node update
the first one should not be necessary because @angular/core depends on the new version of typescript and ng-update will update the project's typescript version to match that.
the second update of @types/node is not relevant for @angular/core. That dependency is introduced into CLI projects by the CLI scaffolding so that we can write e2e tests in typescript - these tests run in node, hence the need for these typings.
I propose that we remove the migration for the typescript update and move the migration for @types/node into CLI rather than @angular/core.
Moving to CLI. @devversion I am not aware of what that part of the |
Angular will only support TS 3.6+ on version 9, and older versions of `@types/node` are incompatible with it and will cause all builds to fail. Related to angular/angular#33250
Angular will only support TS 3.6+ on version 9, and older versions of `@types/node` are incompatible with it and will cause all builds to fail. Related to angular/angular#33250
Angular will only support TS 3.6+ on version 9, and older versions of `@types/node` are incompatible with it and will cause all builds to fail. Related to angular/angular#33250
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Blocked on #32946
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information