feat(@schematics/angular): update @types/node for version 9 #15879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angular will only support TS 3.6+ on version 9, and older versions of `@types/node` are incompatible with it and will cause all builds to fail. Related to angular/angular#33250
filipesilva
added
the
target: major
alan-agius4
reviewed
Oct 19, 2019
| @@ -23,6 +23,7 @@ export function updateDependencies(): Rule { | |||
| 'ng-packagr': latestVersions.ngPackagr, | |||
| 'web-animations-js': '^2.3.2', | |||
| 'codelyzer': '^5.1.2', | |||
| '@types/node': '^12.11.1', | |||
There was a problem hiding this comment.
We should change new projects to use this version there are a bunch of places still configured to use ~10.14.0
I will include it in my TS #15881
|
superseded by #15881 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular will only support TS 3.6+ on version 9, and older versions of
@types/nodeare incompatible with it and will cause all builds to fail.Related to angular/angular#33250