Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngAnimate): setting classNameFilter disables animation inside ng-if #6541

Closed
wants to merge 1 commit into from

Conversation

r3m0t
Copy link
Contributor

@r3m0t r3m0t commented Mar 4, 2014

Request Type: bug

How to reproduce: http://plnkr.co/edit/ylFiapyRcSErWC0aC0L0?p=preview

Component(s): ngAnimate

Impact: small

Complexity: medium

This issue is related to:

Detailed Description:

$animate.enter disables all animations on children while the element is being 'animated into' the document. If classNameFilter is set, animations on children are never re-enabled. This fixes that.

Other Comments:

Closes #6539

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6541)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@matsko
Copy link
Contributor

matsko commented Mar 4, 2014

Excellent work. Please sign the CLA so I can merge this in.

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@r3m0t r3m0t added cla: no and removed cla: yes labels Mar 4, 2014
@tbosch tbosch self-assigned this Mar 6, 2014
@tbosch tbosch added this to the 1.3.x milestone Mar 6, 2014
@tbosch tbosch removed their assignment Mar 6, 2014
@r3m0t r3m0t added cla: no and removed cla: yes labels Mar 7, 2014
@r3m0t
Copy link
Contributor Author

r3m0t commented Mar 12, 2014

Hello, it's signed by Gambit Research LLP.

@r3m0t
Copy link
Contributor Author

r3m0t commented Mar 14, 2014

I just rebased.

@matsko
Copy link
Contributor

matsko commented Mar 14, 2014

Great. I will merge this in shortly.

@matsko
Copy link
Contributor

matsko commented Mar 18, 2014

This was merged last week as 129e2e0

@matsko matsko closed this Mar 18, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

classNameFilter applies to parent elements
4 participants