Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

classNameFilter applies to parent elements #6539

Closed
r3m0t opened this issue Mar 4, 2014 · 2 comments
Closed

classNameFilter applies to parent elements #6539

r3m0t opened this issue Mar 4, 2014 · 2 comments
Labels
component: ngAnimate frequency: moderate severity: broken expected use type: bug
Milestone
1.3.x - superlumi...

Comments

@r3m0t
Copy link
Contributor

r3m0t commented Mar 4, 2014

This behaviour is quite surprising and should be changed or better documented:

http://plnkr.co/edit/ylFiapyRcSErWC0aC0L0?p=preview

Expected: both numbers to fade in.
Actual: the left elements div.slide.ng-enter are children of div.nicer, which doesn't match classNameFilter, so animations are disabled on all its children.
r3m0t pushed a commit to r3m0t/angular.js that referenced this issue Mar 4, 2014
fix(ngAnimate): setting classNameFilter disables animation inside ng-if
e99c513 
Closes angular#6539
@r3m0t r3m0t mentioned this issue Mar 4, 2014
Closed
r3m0t pushed a commit to r3m0t/angular.js that referenced this issue Mar 4, 2014
fix(ngAnimate): setting classNameFilter disables animation inside ng-if
45a7ef1 
Closes angular#6539
@tbosch tbosch self-assigned this Mar 6, 2014
@tbosch tbosch added this to the 1.3.x milestone Mar 6, 2014
@tbosch tbosch removed their assignment Mar 6, 2014
r3m0t pushed a commit to r3m0t/angular.js that referenced this issue Mar 14, 2014
fix(ngAnimate): setting classNameFilter disables animation inside ng-if
cbd7e88 
Closes angular#6539
matsko pushed a commit to matsko/angular.js that referenced this issue Mar 14, 2014
@matsko
fix(ngAnimate): setting classNameFilter disables animation inside ng-if
f3ba397 
Closes angular#6539
@matsko matsko closed this as completed in 129e2e0 Mar 14, 2014
@matsko
Copy link
Contributor

matsko commented Mar 14, 2014

MERGED

@matsko
Copy link
Contributor

matsko commented Mar 14, 2014

Landed as 129e2e0

matsko pushed a commit that referenced this issue Mar 14, 2014
@matsko
fix(ngAnimate): setting classNameFilter disables animation inside ng-if
a41a2a1 
Closes #6539
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: ngAnimate frequency: moderate severity: broken expected use type: bug
Projects
None yet
Milestone
1.3.x - superluminal-nudge
Development

Successfully merging a pull request may close this issue.

fix(ngAnimate): setting classNameFilter disables animation inside ng-if r3m0t/angular.js
3 participants
@matsko @tbosch @r3m0t