This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(input): ngList is updated when array model values are changed #5689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2014 00:01
…he former array data related to angular#1751 When watching arrays, $watchCollection returned the new data both in the newCollection and the oldCollection arguments of the listener
fixes angular#1751 When the model referenced the same same array and the array values where changed, the list wasn't updated. Now watchCollection is used to detect changes in NgModelController. Changes in input.js breaked tests: — select select-multiple should require — select ngOptions ngRequired should treat an empty array as invalid when `multiple` attribute used Changes in select.js fixed them again: changes in the collections should trigger the formatters and render again. BEHAVIOUR CHANGE There is a change in the behaviour of ngList when typing a list. When “a , b” is typed is automatically changed to “a, b”.
ghost
assigned 
|
I think the first commit is wrong. It should be about the change for |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa
to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560
to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429
to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20
to
998c61c
Compare
|
#12783 is a new attempt to fix this. It also shows why we can't simply use $watchCollection watch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1751
Depends on PR #5688
Split of PR #3865
When the model referenced the same same array and the array values
where changed, the list wasn't updated.
Now watchCollection is used to detect changes in NgModelController.
Changes in input.js breaked tests:
— select select-multiple should require
— select ngOptions ngRequired should treat an empty array as invalid when
multipleattribute usedChanges in select.js fixed them again: changes in the collections should trigger the formatters and render again.
BEHAVIOUR CHANGE
There is a change in the behaviour of ngList when typing a list.
When “a , b” is typed is automatically changed to “a, b”.