$watchCollection informs the old collection array values in the second argument of the listener. fixes #1751 #3865
Conversation
…he former array data related to angular#1751 When watching arrays, $watchCollection returned the new data both in the newCollection and the oldCollection arguments of the listener
With the fix on watchCollection, this code needed to be updated to run all previous tests on select.
fixes angular#1751 When the model referenced the same same array and the array values where changed, the list wasn't updated. Now watchCollection is used to detect changes in NgModelController. isEmpty now detects empty arrays BEHAVIOUR CHANGE There is a change in the behaviour of ngList when typing a list. When “a , b” is typed is automatically changed to “a, b”.
|
I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let me know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
I had signed the CLA in the past, but I think I used my gmail address. Anyway, I have signed the CLA twice with both addresses again. |
|
btw it would be much easier and faster to get these changes in if you would create 1 PR for each commit and just mention in the comments that the last two depends on the first one. |
ghost
assigned
|
Thanks for your review. |
$watchCollection correctly informs the old collection values in the second argument of the listener (before it informed an array with the same values as the new collection)
select, input and nglist are affected by this change
There is a behaviour change in ngList, when you type "a , b" it automatically changes the value to "a, b" (this is reflected in inputSpec.js#989 change)