Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

refactor(filterFilter): simplify code by a ternary op instead of if-else #5631

Closed
wants to merge 1 commit into from
Closed

refactor(filterFilter): simplify code by a ternary op instead of if-else #5631

wants to merge 1 commit into from

Conversation

royling
Copy link
Contributor

@royling royling commented Jan 4, 2014

  • use only one IIFE and a ternary op in it, instead of invoking separate IIFEs in if-else (this also completely fixed the same issue closed by PR fix(filter): filter on false properties #3597)
  • also add a spec to verify usage of '$' property in expression object (e.g. {$: 'a'})

@IgorMinar
Copy link
Contributor

lgtm.. waiting for travis to build this before merging

@ghost ghost assigned IgorMinar Jan 4, 2014
@royling
Copy link
Contributor Author

royling commented Jan 4, 2014

weird, seems the build was not triggered by this PR.

@royling
refactor(filterFilter): simplify code by a ternary op instead of if-else
79707e5 
- use only one IIFE and a ternary op in it, instead of invoking separate IIFEs in if-else
(this also completely fixed the same issue closed by PR angular#3597)
- also add a spec to verify usage of '$' property in expression object (e.g. `{$: 'a'}`)
@royling
Copy link
Contributor Author

royling commented Jan 5, 2014

send the changes in another PR #5637 for triggering travis ci build and close this one.

@royling royling closed this Jan 5, 2014
@royling royling deleted the refactor branch January 5, 2014 08:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@IgorMinar IgorMinar

Labels
cla: yes component: misc core type: refactor
Projects
None yet
Milestone
1.2.8
Development

Successfully merging this pull request may close these issues.
2 participants
@royling @IgorMinar