This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(filter): filter on false properties #3597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
Real name: Thomas Dunstan |
| @@ -183,7 +183,7 @@ function filterFilter() { | |||
| })(); | |||
| } else { | |||
| (function() { | |||
| if (!expression[key]) return; | |||
| if (typeof(expression[key]) === undefined) { return; } | |||
There was a problem hiding this comment.
typeof returns a string so this comparison is never true. Use typeof expression[key] === 'undefined'. You should also include one item where the property is not defined in the test.
There was a problem hiding this comment.
Oops! Also, how weird that it wasn't picked up by any other tests. I'll remedy that, too.
Code was evaluating !expression[key] while attempting to see if the key was present, but this was evaluating to true for false values as well as missing keys. Closes angular#2797.
ghost
assigned 
|
Thanks for merging! Now I can upgrade off of 1.0.x. |
royling
added a commit
to royling/angular.js
that referenced
this pull request
Jan 4, 2014
use only one IIFE and a ternary op in it, instead of invoking separate IIFEs in if-else (this also completely fixed the same issue closed by PR angular#3597) also add a spec to verify usage of '$' property in expression object (e.g. `{$: 'a'}`)
royling
added a commit
to royling/angular.js
that referenced
this pull request
Jan 5, 2014
- use only one IIFE and a ternary op in it, instead of invoking separate IIFEs in if-else (this also completely fixed the same issue closed by PR angular#3597) - also add a spec to verify usage of '$' property in expression object (e.g. `{$: 'a'}`)
royling
added a commit
to royling/angular.js
that referenced
this pull request
Jan 5, 2014
- use only one IIFE and a ternary op in it, instead of invoking separate IIFEs in if-else (this also completely fixed the same issue closed by PR angular#3597) - also add a spec to verify usage of '$' property in expression object (e.g. `{$: 'a'}`)
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
- use only one IIFE and a ternary op in it, instead of invoking separate IIFEs in if-else (this also completely fixed the same issue closed by PR angular#3597) - also add a spec to verify usage of '$' property in expression object (e.g. `{$: 'a'}`) Closes angular#5637
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
- use only one IIFE and a ternary op in it, instead of invoking separate IIFEs in if-else (this also completely fixed the same issue closed by PR angular#3597) - also add a spec to verify usage of '$' property in expression object (e.g. `{$: 'a'}`) Closes angular#5637
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code was evaluating !expression[key] while attempting to
see if the key was present, but this was evaluating to true for
false values as well as missing keys.
Closes #2797.