Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Fix #471: issues with input type="number" #481

Closed
wants to merge 1 commit into from

Conversation

technohippy
Copy link
Contributor

Model validators may be interfering with digesting. Validations have to be done before digesting.

@mhevery
Copy link
Contributor

mhevery commented Jan 31, 2014

Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form): http://code.google.com/legal/individual-cla-v1.0.html

@technohippy
Copy link
Contributor Author

I've already signed the CLA for #460. My email address is: [email protected]. Please check it.

@jbdeboer
Copy link
Contributor

jbdeboer commented Feb 4, 2014

Could you add a test to this PR demonstrating how Angular fails without this change?

@mhevery
Copy link
Contributor

mhevery commented Feb 4, 2014

CLA signature found, and verified.

value(NgModelPatternValidator, null);
value(NgModelMinLengthValidator, null);
value(NgModelMaxLengthValidator, null);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should have no effect at running code. Could you please add a test which demonstrates that it fails without this change.

@wienczny
Copy link

wienczny commented Feb 4, 2014

I've found an issue that may be related. Does this bug prevent data binding and updates on input elements if there is an validator attached to the type. For me this happened when using

@mhevery
Copy link
Contributor

mhevery commented Feb 5, 2014

It should not, but only a test can give you a definitive answer. Without a test we are shooting in the dark.

@wienczny
Copy link

wienczny commented Feb 5, 2014

At least the attached patch changes the behavior. You can test this by using the code from angular/angular.dart.tutorial chapter 01. Just replace type="text" with type="email".

jbdeboer added a commit to jbdeboer/angular.dart that referenced this pull request Feb 5, 2014
@jbdeboer jbdeboer closed this in 467b935 Feb 5, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

5 participants