-
Notifications
You must be signed in to change notification settings - Fork 248
Fix #471: issues with input type="number" #481
Conversation
Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road. For individuals (a simple click-through form): http://code.google.com/legal/individual-cla-v1.0.html |
I've already signed the CLA for #460. My email address is: [email protected]. Please check it. |
Could you add a test to this PR demonstrating how Angular fails without this change? |
CLA signature found, and verified. |
value(NgModelPatternValidator, null); | ||
value(NgModelMinLengthValidator, null); | ||
value(NgModelMaxLengthValidator, null); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should have no effect at running code. Could you please add a test which demonstrates that it fails without this change.
I've found an issue that may be related. Does this bug prevent data binding and updates on input elements if there is an validator attached to the type. For me this happened when using |
It should not, but only a test can give you a definitive answer. Without a test we are shooting in the dark. |
At least the attached patch changes the behavior. You can test this by using the code from angular/angular.dart.tutorial chapter 01. Just replace type="text" with type="email". |
Model validators may be interfering with digesting. Validations have to be done before digesting.