Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

add default type attribute for input element #460

Closed

Conversation

technohippy
Copy link
Contributor

Now <input ng-model="myModel" /> does not work because there is not any type attribute. This patch makes this work.

@mhevery
Copy link
Contributor

mhevery commented Jan 29, 2014

Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form): http://code.google.com/legal/individual-cla-v1.0.html

@technohippy
Copy link
Contributor Author

Thank you for your quick reply. I signed it electronically just now.

@jbdeboer
Copy link
Contributor

jbdeboer commented Feb 4, 2014

Could you add a test to this PR? Other than that, this looks like a good change.

@technohippy
Copy link
Contributor Author

I added some tests although they are just copy-and-paste.

@vicb
Copy link
Contributor

vicb commented Feb 4, 2014

I'd rather test than the type="text" attribute is added which is what the code does.

Please also check CONTRIBUTING.md for commit guidelines. Thanks.

make <input ng-model="myModel" /> acceptable
@technohippy
Copy link
Contributor Author

I added a test to check that the type="text" attribute is added.

@vicb
Copy link
Contributor

vicb commented Feb 5, 2014

An other option would be to implement :not in the selector.

@mhevery
Copy link
Contributor

mhevery commented Feb 5, 2014

MERGED: 8f0a8a7

@mhevery mhevery closed this Feb 5, 2014
@technohippy
Copy link
Contributor Author

mhevery
Thanks!

vicb
You are right. Honestly I tried it first but it's beyond me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

4 participants