Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Fix #471: issues with input type="number" #481

Closed
wants to merge 1 commit into from
Closed

Fix #471: issues with input type="number" #481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/directive/module.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,14 @@ part 'ng_model_validators.dart';

class NgDirectiveModule extends Module {
NgDirectiveModule() {
value(NgModelRequiredValidator, null);
value(NgModelUrlValidator, null);
value(NgModelEmailValidator, null);
value(NgModelNumberValidator, null);
value(NgModelPatternValidator, null);
value(NgModelMinLengthValidator, null);
value(NgModelMaxLengthValidator, null);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should have no effect at running code. Could you please add a test which demonstrates that it fails without this change.

value(NgADirective, null);
value(NgBindDirective, null);
value(NgBindTemplateDirective, null);
Expand Down Expand Up @@ -70,13 +78,5 @@ class NgDirectiveModule extends Module {
value(NgNonBindableDirective, null);
value(NgTemplateDirective, null);
value(NgForm, new NgNullForm());

value(NgModelRequiredValidator, null);
value(NgModelUrlValidator, null);
value(NgModelEmailValidator, null);
value(NgModelNumberValidator, null);
value(NgModelPatternValidator, null);
value(NgModelMinLengthValidator, null);
value(NgModelMaxLengthValidator, null);
}
}