-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lint): update tslint #740
Conversation
Style guide rules are missing. You can find some of them which are used by the docs here. |
Also, we could add the rules to force some kind of prefix. like "my-" and tell the users how to override it. |
b2ec394
to
08ad334
Compare
@mgechev @Foxandxss I updated the PR with all the rules in docs link. Please confirm this is what was intended. |
If those are the rules we have at angular.io yes. But I realized that some of them are really strict. After we lint all our codebase I can't tell you that those rules are the best one we can put. In the meantime, sure, you can add those. On the other hand, what do you think about the |
I don't really have an opinion on that. I remember there was some conversation regarding that with @Brocco but don't know anything else. |
@Foxandxss you can define a prefix for selectors via |
Good, that means that we can add those extra rules here and let the user tune it up. Perhaps those commands could modify the lint rules too. |
@Foxandxss I think that can be left to another PR though, as it's a bigger piece of functionality. |
Update tslint config
08ad334
to
723778a
Compare
Update tslint config
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Update tslint config as per @johnpapa, @mgechev, @Foxandxss suggestions.