Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): update tslint #740

Merged
merged 1 commit into from
Jun 2, 2016
Merged

Conversation

filipesilva
Copy link
Contributor

Update tslint config as per @johnpapa, @mgechev, @Foxandxss suggestions.

@mgechev
Copy link
Member

mgechev commented May 12, 2016

Style guide rules are missing. You can find some of them which are used by the docs here.

@Foxandxss
Copy link
Member

Also, we could add the rules to force some kind of prefix. like "my-" and tell the users how to override it.

@filipesilva
Copy link
Contributor Author

@mgechev @Foxandxss I updated the PR with all the rules in docs link. Please confirm this is what was intended.

@Foxandxss
Copy link
Member

If those are the rules we have at angular.io yes. But I realized that some of them are really strict. After we lint all our codebase I can't tell you that those rules are the best one we can put. In the meantime, sure, you can add those.

On the other hand, what do you think about the my- prefixes I said in my last comment?

@filipesilva
Copy link
Contributor Author

I don't really have an opinion on that. I remember there was some conversation regarding that with @Brocco but don't know anything else.

@Brocco
Copy link
Contributor

Brocco commented Jun 1, 2016

@Foxandxss you can define a prefix for selectors via --prefix in both the new and init commands. Also you can tweak that value in angular-cli.json or via ng set defaults.prefix my

@Foxandxss
Copy link
Member

Good, that means that we can add those extra rules here and let the user tune it up.

Perhaps those commands could modify the lint rules too.

@filipesilva
Copy link
Contributor Author

@Foxandxss I think that can be left to another PR though, as it's a bigger piece of functionality.

Update tslint config
@filipesilva filipesilva merged commit 6c77184 into angular:master Jun 2, 2016
@filipesilva filipesilva deleted the tslint-update branch June 2, 2016 02:24
devCrossNet pushed a commit to devCrossNet/universal-cli that referenced this pull request Jun 9, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants