Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tslint is missing custom rules in 1.0.0-beta.6 #1094

Closed
cexbrayat opened this issue Jun 15, 2016 · 3 comments · Fixed by #1108
Closed

tslint is missing custom rules in 1.0.0-beta.6 #1094

cexbrayat opened this issue Jun 15, 2016 · 3 comments · Fixed by #1108
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix

Comments

@cexbrayat
Copy link
Member

  1. OS?
    Mac OSX El Capitan
  2. Versions.
    angular-cli: 1.0.0-beta.6
    node: 6.2.0
    os: darwin x64
  3. Repro steps.
    In a new project, run tslint "src/**/*.ts"
  4. The log given by the failure. Normally this include a stack trace and some
    more information.
throw new Error(ERROR_MESSAGE);
        ^

Error:
            Could not find implementations for the following rules specified in the configuration:
            directive-selector-name
component-selector-name
directive-selector-type
component-selector-type
use-input-property-decorator
use-output-property-decorator
use-host-property-decorator
no-input-rename
no-output-rename
use-life-cycle-interface
use-pipe-transform-interface
component-class-suffix
directive-class-suffix
  1. Mention any other details that might be useful.
    Looks like the rules directory was removed in chore(lint): update tslint #740
    Maybe that's not necessary anymore, but I'm using the last tslint release 3.11, so something must be missing.

Current workaround is to add the rules directory again:

  "rulesDirectory": [
    "node_modules/codelyzer"
  ],

cc @filipesilva

@filipesilva
Copy link
Contributor

@mgechev can you advise?

@filipesilva filipesilva added type: bug/fix P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Jun 16, 2016
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jun 16, 2016
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jun 16, 2016
@filipesilva
Copy link
Contributor

@cexbrayat added a PR doing exactly what you mentioned as a fix. I mistakenly removed that lint config entry.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants