fix(@angular/cli): fix webdriver deep import on yarn

[filipesilva]

Fix #4596

[filipesilva]

Doesn't seem like this fix is enough.

[Meligy]

How about adding webdriver-manager directly to package.json instead of via protractor?

[cexbrayat]

@filipesilva As you were wondering if this was enough, your PR fixes the issue for my project (cli beta.31 + yarn)

[victornoel]

@cexbrayat I guess it doesn't work with npm anymore and that's why it is not enough?

[filipesilva]

Yeah it doesn't work npm with this fix. Not sure what the solution is for now, but the workaround is to update webdriver manually (($npm bin) webdriver-manager update) and to run the e2e command without webdriver (ng e2e --no-webdriver-update).

[Meligy]

Would it make sense to run node_modules/.bin/webdriver-manager as a child process with the project as a working directory for the process?

[Meligy]

That's essentially the CLI doing it the same way as the workaround.

[filipesilva]

That's what we were trying to move away from, running npm scripts in separate processes.

[Meligy]

I think there are potential 2 options:

1 - Add webdriver-manager to devDependencies so that it's hopefully always directly under node_modules. The con is having to sync its version to protractor manually

2 - Add a file check for one of the cases (say NPM, under protractor), and if it doesn't exist, revert back to looking in node_modules. The con is that it's just silly, and might not serve well in the future, but you can worry about this when there are many more cases.

I recommend just going with option 2, as this is a basic failing scenario at the moment.

[filipesilva]

@Meligy I think something like 2 is a pretty good solution for now. Trying both and failing only if neither is there.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}