-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ng e2e
breaks when webdriver-manager out of date
#4640
Comments
Yes, even I'm facing the same issue. 'ng e2e' may not be calling the 'pree2e' script while running. The workaround provided above of running 'pree2e' works though. |
I have the same issue but when running |
We do run I'm not sure why that didn't work in your case. It might be related with the fact that now we use protractor@5, and yo had some old drivers? Not sure. If you can find a way to consistently repro with a new app I can investigate. |
For me the suggested workaround did not work on a newly generated project. |
Downgrading to [email protected] worked for me. |
The issue seems to be with magic-string, `insertLeft(index, content) {
}` It's being called from
I can be ignored |
I had this happen with beta 31, too |
@filipesilva I can confirm that I have protractor installed at 4.0.13 as per my package.json:
I take it that this would have been updated with an I will need to perform further investigation to see if the version change is related to this bug. I'm concerned with the fact that my project's package.json is now out of date with the latest cli's package.json blueprint and has no way of being updated as part of a CLI upgrade. |
@johnpapa @Blasz Running the e2e command without the webdriver update and adding pree2e below fixed this issue ( I use yarn btw) see #4597 "pree2e": "webdriver-manager update --standalone false --gecko false",
"e2e": "ng e2e --no-webdriver-update", @Blasz Also, to be able to migrate, you should copy-paste and merged all cli config files |
We've added a step-by-step update doc for RCs, which we'll keep updated up to 1.0 (including). If this is something we can fix from the CLI side I'd like to, but my understanding is that it's some kind of unsupported behaviour from protractor/webdriver-manager. Does anyone have a better explanation? |
@b-barry's trick did not work for me on a newly generated project, still the same error. I'm using Angular CLI 1.0.0. |
@rkrisztian on a new project? That's really odd. Can you give me a full log please? |
Attached e2e-log.txt. Edit: Okay, that's Firefox, true. Chrome works however. |
Thanks for reporting this issue. This issue is now obsolete due to changes in the recent releases. Please update to the most recent Angular CLI version. If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior. |
To record, I tried "npm install --save-dev protractor@latest", the protractor version turned into: |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
OS?
Ubuntu
Versions.
@angular/cli: 1.0.0-beta.31
Repro steps.
Run
ng e2e
with an out of date webdriver-manager.The log given by the failure.
The log says to update webdriver-manager (which used to happen as a part of the
pree2e
npm script in package.json).Running that pre script manually fixes the problem:
Successful run
The text was updated successfully, but these errors were encountered: