-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(karma): Enable test of global scripts #3122
fix(karma): Enable test of global scripts #3122
Conversation
It is strange - I've done only minor linting fixes, and travis failed (and only for node 6.0). There might be some error with the travis config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR would fix the issue. But this functionality belongs in https://github.com/angular/angular-cli/blob/master/packages/angular-cli/models/webpack-build-test.js instead, using a similar logic as the one found in https://github.com/angular/angular-cli/blob/master/packages/angular-cli/models/webpack-build-common.ts.
Could you apply the fix there instead?
I've tried doing that, but it doesn't work when dealing with complex libraries (like Cesiumjs). That's why I've reverted to changing the |
That's a tough cookie... especially because changes in #3402 will break this approach. I think I need to find a more robust way of adding scripts to the test command, probably by compiling the test config via ts for both dev and release setups. |
Superseded by #3543 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #2897