Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(karma): Enable test of global scripts #3122

Closed

Conversation

YonatanKra
Copy link

Fixes #2897

@YonatanKra
Copy link
Author

It is strange - I've done only minor linting fixes, and travis failed (and only for node 6.0). There might be some error with the travis config.

@YonatanKra YonatanKra closed this Nov 12, 2016
@YonatanKra YonatanKra reopened this Nov 12, 2016
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR would fix the issue. But this functionality belongs in https://github.com/angular/angular-cli/blob/master/packages/angular-cli/models/webpack-build-test.js instead, using a similar logic as the one found in https://github.com/angular/angular-cli/blob/master/packages/angular-cli/models/webpack-build-common.ts.

Could you apply the fix there instead?

@YonatanKra
Copy link
Author

I've tried doing that, but it doesn't work when dealing with complex libraries (like Cesiumjs). That's why I've reverted to changing the karma.conf directly to include the whole node module.
Do you still want me to apply the change, even though it is less robust?

@filipesilva
Copy link
Contributor

That's a tough cookie... especially because changes in #3402 will break this approach.

I think I need to find a more robust way of adding scripts to the test command, probably by compiling the test config via ts for both dev and release setups.

@filipesilva filipesilva self-assigned this Dec 9, 2016
@filipesilva
Copy link
Contributor

Superseded by #3543

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Global libraries won't be auto loaded when running ng test
3 participants