Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Global libraries won't be auto loaded when running ng test #2897

Closed
ye-will opened this issue Oct 26, 2016 · 3 comments · Fixed by #3543
Closed

[Bug] Global libraries won't be auto loaded when running ng test #2897

ye-will opened this issue Oct 26, 2016 · 3 comments · Fixed by #3543
Assignees
@filipesilva
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix

Comments

@ye-will
Copy link

ye-will commented Oct 26, 2016

Libraries in apps[0].scripts of the angular-cli.json won't be loaded when running ng test, that makes all test cases failed.
These libraries must included again in files[] of the karma.conf.js.

OS

Mac OSX (El Capitan)

Versions.

angular-cli: 1.0.0-beta.18
node: 6.8.1
os: darwin x64
@filipesilva
Copy link
Contributor

That's definitely a bug. We'll look into it.

@filipesilva filipesilva added type: bug/fix command: test P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Nov 2, 2016
@filipesilva filipesilva self-assigned this Nov 2, 2016
@filipesilva filipesilva mentioned this issue Nov 4, 2016
Closed
@YonatanKra
Copy link

YonatanKra commented Nov 12, 2016 •
edited
Loading

I've added this: #3122
Solved it on my end.

YonatanKra added a commit to YonatanKra/angular-cli that referenced this issue Nov 12, 2016
@YonatanKra
fix(karma): Enable test of global scripts
c21e1a9 
Fixes angular#2897
@YonatanKra YonatanKra mentioned this issue Nov 12, 2016
Closed
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Dec 13, 2016
@filipesilva
fix(tests): add global scripts in karma plugin
20c5cb6 
Note: renamed and lazy global scripts are not supported.

Fix angular#2897
@filipesilva filipesilva mentioned this issue Dec 13, 2016
Merged
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Dec 13, 2016
@filipesilva
fix(tests): add global scripts in karma plugin
24aed4d 
Note: renamed and lazy global scripts are not supported.

Fix angular#2897
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Dec 21, 2016
@filipesilva
fix(tests): add global scripts in karma plugin
86a4eef 
Note: renamed and lazy global scripts are not supported.

Fix angular#2897
filipesilva added a commit that referenced this issue Dec 22, 2016
@filipesilva
fix(tests): add global scripts in karma plugin (#3543)
1153c92 
Note: renamed and lazy global scripts are not supported.

Fix #2897
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this issue Feb 9, 2017
@filipesilva @MRHarrison
fix(tests): add global scripts in karma plugin (angular#3543)
f7e30a2 
Note: renamed and lazy global scripts are not supported.

Fix angular#2897
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@filipesilva filipesilva

Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix
Projects
None yet
Milestone
No milestone
3 participants
@filipesilva @YonatanKra @ye-will