Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] fix(@angular/build): Ctrl + C not terminating dev-server with SSR #28606

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Oct 9, 2024

Patch version of #28604

This commit provides a workaround for angular#28336, which occurs due to the interaction between `zone.js` and `listr2`. The issue prevents proper termination of the development server using Ctrl + C when dev-server.

Closes: angular#28336
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Oct 9, 2024
@alan-agius4 alan-agius4 requested a review from clydin October 9, 2024 11:44
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 9, 2024
@alan-agius4 alan-agius4 changed the title fix(@angular/build): Ctrl + C not terminating dev-server with SSR [backport] fix(@angular/build): Ctrl + C not terminating dev-server with SSR Oct 9, 2024
@alan-agius4 alan-agius4 merged commit 9445916 into angular:18.2.x Oct 9, 2024
33 checks passed
@alan-agius4 alan-agius4 deleted the vite-des branch October 9, 2024 13:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants