Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/build): Ctrl + C not terminating dev-server with SSR #28604

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

alan-agius4
Copy link
Collaborator

This commit provides a workaround for #28336, which occurs due to the interaction between zone.js and listr2. The issue prevents proper termination of the development server using Ctrl + C when dev-server.

Closes: #28336

This commit provides a workaround for angular#28336, which occurs due to the interaction between `zone.js` and `listr2`. The issue prevents proper termination of the development server using Ctrl + C when dev-server.

Closes: angular#28336
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Oct 9, 2024
@alan-agius4 alan-agius4 requested a review from clydin October 9, 2024 09:07
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 9, 2024
@alan-agius4 alan-agius4 merged commit 549c20a into angular:main Oct 9, 2024
32 of 33 checks passed
@alan-agius4 alan-agius4 deleted the dev-server-terminate branch October 9, 2024 11:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl + C is not working dev-server with SSR
2 participants