fix(@angular-devkit/build-angular): improve rebuild performance with loaders and prebundling #27146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loaders and prebundling Processing overhead has been reduce during resolution when the fallback path is enabled for prebundling due to either prebundling exclusions or custom loader options being present. The resolution logic now follows the same behavior as the underlying bundler's external package option and avoids the need for an additional bundler resolution roundtrip. While the overhead of the plugin itself is still present, the execution cost is now greatly reduced. Further optimizations to conditionally include the plugin based on code analysis heuristics may be considered in the future.
clydin
added
target: patch
sod
reviewed
Feb 24, 2024
Comment on lines
+37
to
39
| // esbuild's external packages option considers any package-like path as external | ||
| // which would exclude paths that are absolute or explicitly relative | ||
| build.onResolve({ filter: /^[^./]/ }, async (args) => { |
There was a problem hiding this comment.
Could this evanw/esbuild#3667 help to exclude this callback to run already in esbuild? Like
const loaders = loaderFileExtensions ? `(${Array.from(loaderFileExtensions).join('|')})$` : '';
const libraries = '^(@angular|rxjs|@ngrx)\/)`';
const exclude = loaders ? `(${libraries}|${loaders})` : libraries;
build.onResolve({ filter: /^[^./]/, exclude }, async (args) => {
There was a problem hiding this comment.
No particularly for this use-case.
There was a problem hiding this comment.
Seems like my esbuild PR is not happening. At least I got no feedback for 3 months. No urgency on my part, as we patch angular cli via yarn patch to apply #27120 ourself.
clydin
added
target: minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processing overhead has been reduce during resolution when the fallback path is enabled for prebundling due to either prebundling exclusions or custom loader options being present. The resolution logic now follows the same behavior as the underlying bundler's external package option and avoids the need for an additional bundler resolution roundtrip. While the overhead of the plugin itself is still present, the execution cost is now greatly reduced. Further optimizations to conditionally include the plugin based on code analysis heuristics may be considered in the future.
Blocked on a separate refactoring to allow typescript path mapping entries to be added to the exclude list of the plugin.