fix(@angular-devkit/build-angular): avoid build performance hit when using custom loader #27120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using custom loader loaders in esbuild aren't really custom code. You can only choose from the loaders that esbuild provides. So I doubt they require this `externalPackagesPlugin` which comes at a pretty steep cost of 1 second per 1500 imports your project has on every build and watch rebuild. fixes angular#27116
alan-agius4
reviewed
Feb 22, 2024
| if ( | ||
| options.loaderExtensions || |
There was a problem hiding this comment.
This is by design, as in some cases loaders need to be configured and applied to node packages.
There was a problem hiding this comment.
Then we stick to webpack I guess, as this made esbuild way slower then what we already have 😢
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loaders in esbuild aren't really custom code. You can only choose from the loaders that esbuild provides. So I doubt they require this
externalPackagesPluginwhich comes at a pretty steep cost of 1 second per 1500importstatements your project has on every build and watch rebuild.fixes #27116
followup to #26923
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information